Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNM MassWeight removal #2479

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 28, 2020

Part of changes required for #2443

Changes made in this Pull Request:

  • Removed MassWeight from gnm.py

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay
Copy link
Member Author

IAlibay commented Jan 28, 2020

As far as I am aware, this is the only part of the analysis methods that was commented for deprecation for a version prior to 1.0 (0.17 in this case).

@IAlibay IAlibay changed the title GNM MassWeight deprecation GNM MassWeight removal Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #2479 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2479      +/-   ##
===========================================
+ Coverage    90.23%   90.25%   +0.02%     
===========================================
  Files          179      179              
  Lines        23284    23281       -3     
  Branches      3010     3009       -1     
===========================================
+ Hits         21010    21012       +2     
+ Misses        1666     1662       -4     
+ Partials       608      607       -1
Impacted Files Coverage Δ
package/MDAnalysis/analysis/gnm.py 96.06% <ø> (-0.1%) ⬇️
package/MDAnalysis/lib/util.py 88.56% <0%> (+0.29%) ⬆️
package/MDAnalysis/coordinates/TRJ.py 94.87% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be5c98...233ef43. Read the comment docs.

@richardjgowers richardjgowers merged commit b567168 into MDAnalysis:develop Jan 29, 2020
@richardjgowers
Copy link
Member

thanks @IAlibay gotta love the net negative linechange PRs!

@IAlibay
Copy link
Member Author

IAlibay commented Jan 29, 2020

thanks @IAlibay gotta love the net negative linechange PRs!

Give me ~ a day, there's plenty of removals that need to get done for 1.0 😅

@IAlibay IAlibay deleted the deprecate-pre1 branch January 29, 2020 16:36
@IAlibay IAlibay mentioned this pull request Jan 29, 2020
6 tasks
@fiona-naughton fiona-naughton added maintainability deprecation Deprecated functionality to give advance warning for API changes. labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecated functionality to give advance warning for API changes. maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants