-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled coverage for cython #2029
Conversation
I think @stefanv and the scikit-image team are quite interested in doing this for their library as well so cc'ing them here. |
@tylerjereddy I'm just seeing if it's as easy as these two lines... if it is I'll bring them in :) |
@richardjgowers it basically is!.. with one caveat: lines with "cdef" are marked as "not covered" even if they actually are. This is a well known bug/issue (see cython/cython#1461). |
Codecov Report
@@ Coverage Diff @@
## develop #2029 +/- ##
===========================================
+ Coverage 88.59% 88.59% +<.01%
===========================================
Files 143 143
Lines 17305 17361 +56
Branches 2649 2658 +9
===========================================
+ Hits 15331 15381 +50
- Misses 1376 1379 +3
- Partials 598 601 +3
Continue to review full report at Codecov.
|
Hmm this is weird. When I run locally, the ascii table printout doesn't have any .pyx files, but if I look inside the |
…environment variable CYTHON_TRACE_NOGIL is set
@Fenil3510 for your GSoC project proposal "Cythonizing ASCII Readers/Parser", the discussion here should be relevant. |
This PR can be closed as #2255 solves it. |
Fixes #443
Changes made in this Pull Request:
PR Checklist