Issue 1940 pickle chain reader #1945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is WIP. I also added a test for CRDReader (somewhat unrelated) because I didn't see one – maybe someone can tell me where all SingeFrameReaders are tested nowadays? |
- all readers - ChainReader (special case)
orbeckst
force-pushed
the
issue-1940-pickle-ChainReader
branch
from
04972f3 to
2318ed8
Compare
|
rebased against develop (mainly to trigger codecov) |
|
Note: There's no code in this PR yet that makes the ChainReader picklable, only tests that will need to pass. Feel free to pick it up! |
|
@yuxuanzhuang solved it in PR #2815 and #2723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1940
Changes made in this Pull Request:
PR Checklist