Dcd use istart information #1768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A DCD has two byte positions to store the length of the remark section. First a it reads number of bytes in the remark plus 4. Afterwards it has the number of 80 character sections. These two numbers have to match. So far we wrote first that we use 164 chars and three 80 character blocks, 164 != 80*3 + 4 Now we corrected that and state correctly we write 244 bytes in the remark section. We never noticed that because our reader ignores the information about the byte length on looks only at the number of blocks. As a side note here. DCD remarks always have have to be a multiple of 80 in length.
Programs who use DCD have different conventions for istart, the starting frame of the trajectory. Because of this we now allow it to be set by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
istartinformation stored in the dcd. This means we don't report the correct timestep in the dcd. This PR tries to fix this. It's also made on top of fix header length in dcd #1767 .PR Checklist