Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a syntax error in MDAnalysis.__init__ #1432

Merged
merged 2 commits into from
Jun 24, 2017
Merged

Fix a syntax error in MDAnalysis.__init__ #1432

merged 2 commits into from
Jun 24, 2017

Conversation

jbarnoud
Copy link
Contributor

The PR #1375 introduced a syntax error in MDAnalysis.init. This
commit fixes the defective line.

See comment #1418 (comment) and bellow.

The PR #1375 introduced a syntax error in MDAnalysis.__init__. This
commit fixes the defective line.
@utkbansal
Copy link
Member

The test testsuite.MDAnalysisTests.utils.test_deprecated.test_collections_NotImplementedError fails because it cannot reference collections which was removed in the same commit here.

@jbarnoud
Copy link
Contributor Author

I still have an error that I do not understand:

ERROR: Setting the resids of atoms changes their residue membership.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jon/Envs/mda2/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/jon/dev/mdanalysis/testsuite/MDAnalysisTests/plugins/knownfailure.py", line 58, in inner
    raise KnownFailureException(msg)
KnownFailureException: Test skipped due to expected failure

Cleanup: deleting offset files in /home/jon/dev/mdanalysis/testsuite/MDAnalysisTests/data
----------------------------------------------------------------------

The error happens in core.test_topologyattrs.TestResids.test_set_atoms.

By the way, this PR is a duplicate of @kain88-de's #1431. Max shot first.

@kain88-de
Copy link
Member

Max shot first.

But seems like I missed.

@kain88-de kain88-de merged commit fe0b886 into develop Jun 24, 2017
@kain88-de kain88-de deleted the emergency-fix branch June 24, 2017 14:01
@kain88-de
Copy link
Member

@jbarnoud thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants