Explicitly define __hash__ for groups #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardjgowers
requested changes
Jun 13, 2017
| b = getattr(u, level_b)[0:-1] | ||
| yield _hash_not_equal, a, b | ||
|
|
||
|
|
There was a problem hiding this comment.
these tests are good, but you also need to check the cross universe case
|
|
||
| u = make_Universe(size=(3, 3, 3)) | ||
| levels = ('atoms', 'residues', 'segments') | ||
| for level_a in levels: |
There was a problem hiding this comment.
just stylistic, but I'd use itertools here
There was a problem hiding this comment.
I spent some time today removing itertools use from cython function. It obviously messed up with my brain.
jbarnoud
force-pushed
the
issue-1397-group-hash
branch
from
88ed46b
to
964845c
Compare
|
I forced pushed an amended commit. I had to fix the reference to the issue in the initial commit message. |
richardjgowers
requested changes
Jun 13, 2017
package/CHANGELOG
Outdated
| @@ -26,7 +26,7 @@ Changes | |||
|
|
|||
| 06/03/17 utkbansal, kain88-de, xiki-tempula, kaplajon, wouterboomsma, | |||
| richardjgowers, Shtkddud123, QuantumEntangledAndy, orbeckst, | |||
| kaceyreidy | |||
| kaceyreidy, jbarnoud | |||
jbarnoud
force-pushed
the
issue-1397-group-hash
branch
2 times, most recently
from
e0810d9
to
1717886
Compare
richardjgowers
approved these changes
Jun 13, 2017
|
Travis full ran into time limit. I restarted it but not sure if it will complete. |
4 tasks
|
I have a moment... I will rebase against develop and force push. |
Groups (AtomGroup, ResidueGroup, SegmentGroup) cannot be stored in sets or used as dict key if they are not hashable. In python 3, the __hash__ method is not defined implicitly anymore when a class has a __eq__ method. Fixes #1397
orbeckst
force-pushed
the
issue-1397-group-hash
branch
from
1717886
to
e3d5818
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups (AtomGroup, ResidueGroup, SegmentGroup) cannot be stored in sets
or used as dict key if they are not hashable. In python 3, the hash
method is not defined implicitly anymore when a class has a eq method.
Fixes #1397
PR Checklist
[ ] Docs?