PEP8 changes to topologyattrs: Fixes #1045 #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kain88-de
force-pushed
the
issue-363-pep8-topolattr
branch
from
1682827
to
d3b64f9
Compare
kain88-de
changed the title
|
@richardjgowers This wasn't done. Sorry for not including a WIP. |
|
No worries. Tbh it's a lot easier to review the pep8/aesthetic changes and actual code changes separate. |
|
I'll usually try to keep the PEP8 and actual code changes in separate commits to ease the review. |
abiedermann
pushed a commit
to abiedermann/mdanalysis
that referenced
this pull request
Jan 5, 2017
* pep8 changes topologyattrs * pep8 changes test file * add license to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1045
PEP8 changes. With that I found some bugs. Missing imports and the self argument from member functions is often called group. For the unit-test still have to be written.