Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmarks to > 3.7 #3430

Closed
hmacdope opened this issue Sep 29, 2021 · 3 comments · Fixed by #3521
Closed

Move benchmarks to > 3.7 #3430

hmacdope opened this issue Sep 29, 2021 · 3 comments · Fixed by #3521

Comments

@hmacdope
Copy link
Member

Expected behavior

Since support has been dropped for 2.7 and 3.6 should bump the benchmarks from the current 2.7 python up to whatever version is appropriate.

This is mainly a reminder to change the value in asv.conf.json from:

    "pythons": ["2.7"],

to whatever version is appropriate once bench environment is setup.

Linked to MDAnalysis/benchmarks#11

Actual behavior

tests fail to run unless pythons=2.7 is commented out.

Code to reproduce the behavior

running the benchmarks with asv run or asv continuous

@orbeckst
Copy link
Member

See also MDAnalysis/benchmarks#11

@orbeckst
Copy link
Member

orbeckst commented Feb 7, 2022

MDAnalysis/benchmarks#11 has been closed and the benchmarks are running again.

@orbeckst orbeckst closed this as completed Feb 7, 2022
@orbeckst
Copy link
Member

orbeckst commented Feb 7, 2022

oops, have to fix this in MDA ...

@orbeckst orbeckst reopened this Feb 7, 2022
orbeckst added a commit that referenced this issue Feb 7, 2022
- fix #3430
- automated benchmarks were updated (see MDAnalysis/benchmarks#11)
IAlibay pushed a commit that referenced this issue Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants