Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation warnings for API changes #1383

Closed
3 tasks done
richardjgowers opened this issue Jun 4, 2017 · 1 comment · Fixed by #1403
Closed
3 tasks done

add deprecation warnings for API changes #1383

richardjgowers opened this issue Jun 4, 2017 · 1 comment · Fixed by #1403
Assignees
Labels
Milestone

Comments

@richardjgowers
Copy link
Member

richardjgowers commented Jun 4, 2017

Ideally we should push out deprecation warnings as soon as we know it's happening. Related issues:

@richardjgowers richardjgowers added this to the 0.16.x milestone Jun 4, 2017
@orbeckst
Copy link
Member

@kain88-de I would do the deprecation warnings in 0.16.2; yes, not much time to adapt but fully consistent with semantic versioning. It's pretty clear to say "if you still want timeseries then get the last release in the 0.16 cycle". And we're still in 0.x so we are allowed to move a bit faster.

The alternative would be to make 0.17 for the deprecation warning and 0.18 to remove Timeseries. But these would be two "big" releases in quick succession with 0.17 really not having very much content, especially when comparing to 0.16 and 0.15. This seems more confusing than using a light-weight patch level release like 0.16.2 for the purpose. We might even do a 0.16.3 if necessary, e.g. for restructuring testing.

@kain88-de kain88-de mentioned this issue Jun 15, 2017
11 tasks
@orbeckst orbeckst self-assigned this Jun 15, 2017
orbeckst added a commit that referenced this issue Jun 15, 2017
- closes #1383
- included deprecations:
  - #1373 Timeseries (targeted for 0.17)
    Note that the deprecation for core.Timeseries will always show up;
    this is deliberate so that users WILL see it as it will be gone in
    the next release!
  - #1377 Quick selectors (target 1.0)
  - #782 flags (target 1.0)
- updated CHANGELOG
kain88-de pushed a commit that referenced this issue Jun 20, 2017
- closes #1383
- included deprecations:
  - #1373 Timeseries (targeted for 0.17)
    Note that the deprecation for core.Timeseries will always show up;
    this is deliberate so that users WILL see it as it will be gone in
    the next release!
  - #1377 Quick selectors (target 1.0)
  - #782 flags (target 1.0)
- updated CHANGELOG
richardjgowers pushed a commit that referenced this issue Jun 21, 2017
- closes #1383
- included deprecations:
  - #1373 Timeseries (targeted for 0.17)
    Note that the deprecation for core.Timeseries will always show up;
    this is deliberate so that users WILL see it as it will be gone in
    the next release!
  - #1377 Quick selectors (target 1.0)
  - #782 flags (target 1.0)
- updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants