Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed testing dependencies in deploy.yaml #55

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

ianmkenney
Copy link
Collaborator

Changes made in this Pull Request:

  • "pyest" changed to "pytest"
  • Added MDAnalysisTests

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #55 (ea8982d) into main (53c47a4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change "shell" on line 18 to just be "bash" please?

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@ianmkenney
Copy link
Collaborator Author

Do we want to install sklearn for testing as well?

@IAlibay
Copy link
Member

IAlibay commented Nov 9, 2023

Do we want to install sklearn for testing as well?

sure!

@ianmkenney ianmkenney merged commit 8df686c into main Nov 9, 2023
24 checks passed
@ianmkenney ianmkenney deleted the deployment_fix branch November 9, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants