-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cibuildwheel deployment #22
Conversation
This should do the trick, it'll need testing in an actual deployment though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine. Am I understanding correctly that we will be able to get the wheels on pull requests when tags are pushed? If so then definitely good to go!
So the intent here is that a tag will auto push to testpypi and a release will push to pypi, the PR trigger needs to be removed before we merge |
- name: Build sdist | ||
run: pipx run build --sdist | ||
|
||
- name: upload artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From this section, do we get the wheels in PRs where tags are pushed? For local testing and whatnot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "in PRs"?
When you push tags the wheels will be uploaded to testpypi directly so you can pull them down and test as necessary. You'll also get the artifacts stored locally but that's the exact same thing as whatt's on testpypi (unless the testpypi upload failed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all fine. My question is if I make a PR and one of the commits has a tag of the 0.1.1-rc_*
family, will the resulting wheel be sent to TestPyPI or is it just when the merge into main
happens and we add a proper 0.1.1
tag? It seems from your explanation in the main thread that all of this CI is only relevant in the main
branch though. It doesn't matter too much either way, I just want to know if there is any reason to add an rc
tag inside of a PR or just wait until it's in main
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, oops, that's why you're removing the pull trigger.
To better explain how this work:
|
Alright sounds good, I'm good to merge whenever then! |
Fixes #20
Changes made in this Pull Request:
PR Checklist