-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated deployment to PyPI on release #3
Conversation
@IAlibay Could you take a look at the |
By other MDAKit you mean "other Cython using kits" right? i.e. cibuildwheels isn't suitable for pure python kits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For pure python you should instead use the pypi-deployment action (I assume PSA is indeed pure python).
I figured it wouldn't be the best reference for that reason, I'll just rewrite from scratch then! Thanks |
Please don't rewrite from scratch and use the reusable action - it is there so we can align across all our repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially you want to just have this workflow file: https://github.com/MDAnalysis/mda-xdrlib/blob/main/.github/workflows/deploy.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we can't test if it works without merging? So we'll merge this and then do a 1.0.1 release?
The PyPi metadata doesn't have a link to a documentation page. Enable
PathSimAnalysis/pyproject.toml
Lines 42 to 44 in 3267dee
# [project.urls] | |
# source = "https://github.com/MDAnalysis/pathsimanalysis" | |
# documentation = "https://pathsimanalysis.readthedocs.io" |
MDAnalysis is not the only dependency in
PathSimAnalysis/pyproject.toml
Line 21 in 3267dee
"MDAnalysis>=2.0.0", |
import numpy as np
from scipy import spatial, cluster
from scipy.spatial.distance import directed_hausdorff
import matplotlib
so they all need to be explicitly listed in pyproject.toml
(important for PyPi!) and also in devtools/conda-envs/test_env.yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me. Let's first see if MDAnalysis/waterdynamics#8 works, given that it's essentially implementing the same workflow. If any problems emerge there then we can fix them here, too.
Assuming all is fine, we can then do a 1.0.1 here.
The package should automatically be uploaded to PyPI when a release is made.