Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated deployment to PyPI on release #3

Merged
merged 17 commits into from
Oct 13, 2023
Merged

Automated deployment to PyPI on release #3

merged 17 commits into from
Oct 13, 2023

Conversation

ianmkenney
Copy link
Member

The package should automatically be uploaded to PyPI when a release is made.

@ianmkenney
Copy link
Member Author

@IAlibay Could you take a look at the deploy.yaml workflow? I took it from mdaencore, which you made. If this does the job, then it should be straightforward to move to other MDAKits.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #3 (a01de02) into main (3267dee) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@IAlibay
Copy link
Member

IAlibay commented Oct 11, 2023

@IAlibay Could you take a look at the deploy.yaml workflow? I took it from mdaencore, which you made. If this does the job, then it should be straightforward to move to other MDAKits.

By other MDAKit you mean "other Cython using kits" right? i.e. cibuildwheels isn't suitable for pure python kits

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For pure python you should instead use the pypi-deployment action (I assume PSA is indeed pure python).

@ianmkenney
Copy link
Member Author

I figured it wouldn't be the best reference for that reason, I'll just rewrite from scratch then! Thanks

@ianmkenney ianmkenney temporarily deployed to pypi October 11, 2023 23:59 — with GitHub Actions Inactive
@ianmkenney ianmkenney temporarily deployed to testpypi October 11, 2023 23:59 — with GitHub Actions Inactive
@ianmkenney ianmkenney temporarily deployed to pypi October 12, 2023 00:18 — with GitHub Actions Inactive
@ianmkenney ianmkenney temporarily deployed to testpypi October 12, 2023 00:18 — with GitHub Actions Inactive
@IAlibay
Copy link
Member

IAlibay commented Oct 12, 2023

I figured it wouldn't be the best reference for that reason, I'll just rewrite from scratch then! Thanks

Please don't rewrite from scratch and use the reusable action - it is there so we can align across all our repos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially you want to just have this workflow file: https://github.com/MDAnalysis/mda-xdrlib/blob/main/.github/workflows/deploy.yaml

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we can't test if it works without merging? So we'll merge this and then do a 1.0.1 release?

The PyPi metadata doesn't have a link to a documentation page. Enable

# [project.urls]
# source = "https://github.com/MDAnalysis/pathsimanalysis"
# documentation = "https://pathsimanalysis.readthedocs.io"
for docs and source.

MDAnalysis is not the only dependency in

"MDAnalysis>=2.0.0",
— we also have

import numpy as np
from scipy import spatial, cluster
from scipy.spatial.distance import directed_hausdorff
import matplotlib

so they all need to be explicitly listed in pyproject.toml (important for PyPi!) and also in devtools/conda-envs/test_env.yaml.

@ianmkenney ianmkenney requested a review from orbeckst October 13, 2023 18:42
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. Let's first see if MDAnalysis/waterdynamics#8 works, given that it's essentially implementing the same workflow. If any problems emerge there then we can fix them here, too.

Assuming all is fine, we can then do a 1.0.1 here.

@ianmkenney ianmkenney temporarily deployed to deploy October 13, 2023 22:06 — with GitHub Actions Inactive
@ianmkenney ianmkenney merged commit a93a301 into main Oct 13, 2023
@ianmkenney ianmkenney deleted the PyPI_release branch October 13, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants