fix doc deployment #133
Merged
fix doc deployment #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
orbeckst
commented
Oct 21, 2023
orbeckst
commented
- fix doc CI fails #132
- updated doc workflow with more recent code from mdaencore's docs.yaml:
- modern parameters for conda-incubator/setup-miniconda@v2
- use Python 3.11 for building docs
- use ci/environment.yaml
- now also build on PR (as a test), only deploy on merge
- canonical package name of sphinx-sitemap in environment (prefer dash to underscore)
- updated requirements.txt (at least pro-forma, not sure if we use it)
- fix #132 - updated doc workflow with more recent code from mdaencore's docs.yaml: - modern parameters for conda-incubator/setup-miniconda@v2 - use Python 3.11 for building docs - use ci/environment.yaml - now also build on PR (as a test), only deploy on merge - canonical package name of sphinx-sitemap in environment (prefer dash to underscore) - updated requirements.txt (at least pro-forma, not sure if we use it)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 5 5
Lines 747 747
Branches 127 127
=======================================
Hits 654 654
Misses 56 56
Partials 37 37 ☔ View full report in Codecov by Sentry. |
lilyminium
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
LGTM, thanks for the fix @orbeckst!
Searching through the repo didn't turn up any matches for requirements.txt being used anywhere, best to keep it up-to-date as you're doing here unless we remove it though.
| - name: deploy docs | ||
| uses: peaceiris/actions-gh-pages@v3 | ||
| if: github.event_name != 'pull_request' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.