Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import bug #2

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix import bug #2

merged 1 commit into from
May 2, 2023

Conversation

flow-jort
Copy link

The wrong import cause the isMatch function to be undefined. This was caused by a version upgrade a few commits back.

@MCKanpolat MCKanpolat merged commit b0314e8 into MCKanpolat:main May 2, 2023
@Romanitho
Copy link

Hi. Sorry to comment here, but don't know where to open an issue.

In my testing scenario, I pushed a commit with #minor message and then manually start the GitHub Action.
Here the log on my Action:
image

it creates a new version using default setting instead of increasing minor version:
image
1.21.1-8 instead of 1.22.0
Any help to understand how it should work will be much appreciated.

Thanks

@MCKanpolat
Copy link
Owner

Hi @Romanitho ,
Your releaseType parameter is prerelease so its generating prerelease version number. Try with releaseType: patch

@Romanitho
Copy link

Hi, thanks for your help. But it doesn't seem to work. In fact, I would thought that I could have a nightly build release with incremental prerelease number by default, except if I specify another type in commit message. But it's a nice to have, I handle that with another github action task today, so I'm ok with that.
Anyway, thanks for your action, it helps ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants