Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare page improvement #108

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

aditya-chari25
Copy link
Contributor

Description

This Pull-Request is response to the issue #101
The compare page has been changed and it includes distance (delivery purpose), description, remove feature

Motivation and Context

  1. Basically the comparison page in this we compare each and every feature column wise
  2. The features are "Price, Distance (can be used for delivery in future), brands, description (which can be changed by putting actual description in future)"
  3. And remove feature we can add or subtract products as and when possible
  4. This is how changes are done, new files were added and the compare page icon is redirected to that directory from header.js
  5. You can see the video below for the live demo.

Video :

compare-page.mp4

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nest-ondc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 2:17pm
nest-ondc-arzx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 2:17pm

@MAVRICK-1
Copy link
Owner

@aditya-chari25 great work, it is responsive?

@aditya-chari25
Copy link
Contributor Author

Ye

@aditya-chari25 great work, it is responsive?

Yeah, now I have added the media-queries for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants