Fix for Feature Importance Local Plot Failure After Global Plot #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604
Description:
This PR addresses a bug in Shapash where plotting the feature importance local plot after the feature importance global plot leads to a failure due to missing value computations. The issue arises when the necessary values for the local plot are not computed or stored after rendering the global plot.
Changes Made:
Ensure Value Computation:
Adjusted the workflow to ensure that all required values for the local feature importance plot are computed and stored when plotting the local plot.
Separation of Computations:
Modified the logic to ensure that both the global and local plots can be rendered independently or sequentially without causing any conflicts or missing computations.