Implement looking up usernames by using specific API #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GET /users API is batched and resolving the usernames on large instances fails. There is a dedicated API to map user IDs to users, which get a list of user_ids as an argument: https://api.mattermost.com/#tag/users%2Fpaths%2F~1users~1ids%2Fpost
|
So basically the previous code would only get 60 users at a time, correct? |
|
Yes, 60 by default. This can be expanded to 200 using the And anyway, sending a POST to |
|
Makes sense. Also the code is much nicer now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GET /users API is batched and resolving the usernames on large
instances fails.
There is a dedicated API to map user IDs to users, which get a list of
user_ids as an argument:
https://api.mattermost.com/#tag/users%2Fpaths%2F~1users~1ids%2Fpost