Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken upgrade path for Homebrew Cask: sublime-text3 #196

Closed
trinitronx opened this issue Jul 29, 2023 · 4 comments · Fixed by Homebrew/homebrew-cask-versions#17278 or Homebrew/homebrew-cask#151961
Closed

Broken upgrade path for Homebrew Cask: sublime-text3 #196

trinitronx opened this issue Jul 29, 2023 · 4 comments · Fixed by Homebrew/homebrew-cask-versions#17278 or Homebrew/homebrew-cask#151961
Assignees
@trinitronx
Labels
bug
Milestone
macOS Monterey 12...

Comments

@trinitronx
Copy link
Collaborator

trinitronx commented Jul 29, 2023 •
edited
Loading

Lyra and old rpco box are still stuck on removed Cask: sublime-text3.

It appears that 2 things happened:

  1. sublime-text3 Cask was removed in: Homebrew/homebrew-cask-versions@8d7ef62
  2. Cask was replaced with sublime-text in Homebrew/homebrew-casks

This was both a Cask rename, and Tap migration. However, the updates to tap_migrations.json, and cask_renames.json must have been missed.

As a result, old systems still stuck on the removed sublime-text3 were left without an upgrade path, and files were leftover on the system:

  • /usr/local/Caskroom/sublime-text3/.metadata/Build 3083/20150608071345.171/Casks/sublime-text3.rb
  • /Applications/Sublime Text (3143).app

Additionally, Homebrew itself changed over the years and deprecated many DSL constructs that this old Cask definition was using, and this version was still leftover in the $(brew --caskroom)/sublime-text3/.metadata folder. A copy of the old deprecated and broken Cask. Therefore, brew was stuck in a state of throwing errors every operation that involved reading this Cask, including on brew update, brew remove sublime-text3, brew zap sublime-text3, brew upgrade sublime-text3, etc...

Goals of this task:

  1. Add proper upgrade path for this Cask:
  • Add to Homebrew/homebrew-cask/cask_renames.json to flag as a renamed Cask
  • Add to Homebrew/homebrew-cask-versions/tap_migrations.json to pave way for brew upgrade path to homebrew-cask
  1. Migrate old systems off the old sublime-text3 to sublime-text
  • brew upgrade --verbose --debug --force sublime-text3
  1. Check and/or Fix any breakages for lyraphase_workstation::sublime_text_settings recipe & config files.
@trinitronx trinitronx converted this from a draft issue Jul 29, 2023
@trinitronx trinitronx self-assigned this Jul 29, 2023
@trinitronx trinitronx added this to the macOS Monterey 12.6.8 milestone Jul 29, 2023
@trinitronx trinitronx added the bug label Jul 29, 2023
This was referenced Jul 29, 2023
Merged
Merged
@trinitronx trinitronx changed the title Fix upgrade path for Homebrew Cask: sublime-text3 Broken upgrade path for Homebrew Cask: sublime-text3 Jul 29, 2023
trinitronx added a commit to trinitronx/homebrew-cask that referenced this issue Jul 29, 2023
@trinitronx
fix: Add missing Cask rename: sublime-text3 -> sublime-text
713f40e 
Refs:

- Cask removed in: Homebrew/homebrew-cask-versions@8d7ef62
- Tap Migration PR: Homebrew/homebrew-cask-versions#17278
- Fixes: LyraPhase/sprout-wrap#196
trinitronx added a commit to trinitronx/homebrew-cask-versions that referenced this issue Jul 29, 2023
@trinitronx
fix: Add missing Tap migration: sublime-text3 -> homebrew/cask/sublim…
b96a08d 
…e-text

Refs:

  - Cask removed in: 8d7ef62
  - Rename PR: Homebrew/homebrew-cask#151961
  - Fixes: LyraPhase/sprout-wrap#196
@trinitronx trinitronx mentioned this issue Jul 30, 2023
Open
@trinitronx
Copy link
Collaborator Author

Pushed PRs:

Status: Waiting on review

@trinitronx
Copy link
Collaborator Author

Moving out target date to next week

@trinitronx
Copy link
Collaborator Author

  • Bumped PRs to avoid github-actions stale bot
  • Posted RFC w/ping to Homebrew maintainers
  • Pushed target date out to end of week

Status: Waiting on response + review

@trinitronx
Copy link
Collaborator Author

👏 🎉 Merged! Many thanks to @bevanjkay 🙏

@github-project-automation github-project-automation bot moved this from In Progress to Done in LyraPhase Sprout Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trinitronx trinitronx

Labels
bug
Projects
LyraPhase Sprout
Status: Done
Milestone
macOS Monterey 12.6.8
1 participant
@trinitronx