Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix delete #898

Merged
merged 4 commits into from
Jan 31, 2021
Merged

fix delete #898

merged 4 commits into from
Jan 31, 2021

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 30, 2021

fixes #890

should be fixed with this one. (hopefully)

@codecov
Copy link

codecov bot commented Jan 30, 2021 •
edited
Loading

Codecov Report

Merging #898 (9d8845e) into master (77092c2) will decrease coverage by 1.69%.
The diff coverage is 100.00%.

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria ildyria requested a review from kamil4 January 30, 2021 19:05
@ildyria ildyria added the High Priority High priority issues label Jan 30, 2021
kamil4
kamil4 approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane and appears to handle correctly the cases that were failing before.

@ildyria ildyria merged commit 2071a87 into master Jan 31, 2021
@ildyria ildyria deleted the fix-890 branch January 31, 2021 10:41
@ildyria ildyria removed the High Priority High priority issues label Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why I deleted selected albums and the photos still in the recent Album
2 participants
@ildyria @kamil4