Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rss): avoid display feed link in HTML if RSS option is disabled #810

Merged
merged 1 commit into from
Dec 12, 2020
Merged

fix(rss): avoid display feed link in HTML if RSS option is disabled #810

merged 1 commit into from
Dec 12, 2020

Conversation

yoshinorin
Copy link
Contributor

Hi, I found the title issue :)

Description

Currently, lychee always displays a link for feed on HTML even if rss_enable option is false.

<link rel="alternate" type="application/atom+xml" href="http://localhsot:90/feed" title="Latest pictures">

Implementation

  • IndexController, PageController, and ViewController checks the rss_enable setting and return true/false to head.blade.php.
  • head.blade.php receive true/false from them.
    • if true, displays a link feed.
    • if false, does not display a link feed.

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria ildyria merged commit 4bad2d5 into LycheeOrg:master Dec 12, 2020
@ildyria
Copy link
Member

ildyria commented Dec 12, 2020

Thank you. :)

@yoshinorin yoshinorin deleted the fix/disable-feedlink-in-html branch December 13, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshinorin @ildyria