Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 7.3 is dead, long live PHP 7.4! #799

Merged
merged 2 commits into from
Nov 28, 2020
Merged

PHP 7.3 is dead, long live PHP 7.4! #799

merged 2 commits into from
Nov 28, 2020

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 23, 2020

No description provided.

@pchampio
Copy link
Contributor

As a reminder, LycheeOrg/Lychee-Docker uses php-fpm7.3.
https://github.com/LycheeOrg/Lychee-Docker/blob/50442d3a520e2d1a86c741183a1e3e641caec363/entrypoint.sh#L120

@ildyria
Copy link
Member Author

ildyria commented Nov 23, 2020

@pchampio thank you for pointing that one out! 😱

Well, it would be a good idea to fix it @d7415 😄

@ildyria ildyria mentioned this pull request Nov 23, 2020
Closed
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #799 (6b22342) into master (7751459) will decrease coverage by 1.90%.
The diff coverage is 100.00%.

d7415
d7415 approved these changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but looks good. Most of the PHP changes seem to be the ones you prepared in advance.

The Docker images don't support this yet as they haven't been built. But they also don't contain this for the same reason so that's ok.

Lychee-Docker master branch is ready, so the next build will support this.

Merge when ready!

@ildyria ildyria merged commit bd13c41 into master Nov 28, 2020
@ildyria ildyria deleted the death-of-php-7.3 branch November 28, 2020 14:43
@ildyria ildyria mentioned this pull request Dec 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ildyria @pchampio @d7415