Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the provided password against all albums #727

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Check the provided password against all albums #727

merged 4 commits into from
Sep 17, 2020

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented Sep 15, 2020 •
edited
Loading

Fixes #724

@kamil4 kamil4 changed the title Check the provided password against all ablums Check the provided password against all albums Sep 15, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020 •
edited
Loading

Codecov Report

Merging #727 into master will decrease coverage by 1.54%.
The diff coverage is n/a.

d7415
d7415 approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

ildyria
ildyria requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some refinement to avoid looping over ALL albums.

@kamil4
Copy link
Contributor Author

kamil4 commented Sep 16, 2020

Should be good to go now...

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kamil4 kamil4 merged commit b684ee0 into master Sep 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-724 branch September 17, 2020 18:24
@kamil4 kamil4 mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria requested changes

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] - heirarchical password check for password protected albums
3 participants
@kamil4 @ildyria @d7415