Add functionality to apply lossless image optimization #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2020
ildyria
reviewed
Jul 11, 2020
tmp-hallenser
commented
Jul 11, 2020
Good idea. The library already provides some logging, we need to specify a logging interface (type |
|
What I am also worried, is, if you enable the optimizer but the software are not here, does it raises exceptions or does it just append to the logs ? |
|
@tmp-hallenser can you double check ? |
Logger functionality has been fixed in v1.6.2
|
Kudos, SonarCloud Quality Gate passed!
|
|
works, thanks. Nice job with the logger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement lossless image optimization (#630)
Uploaded original photo is not touched, only medium, small and thumbnails.
Requirements: jpegoptim, optipng, pngquant, gifsicle, webp