Feature/ghostbust dead symlinks #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-phillips
force-pushed
the
feature/ghostbust-dead-symlinks
branch
from
0835160
to
8683ac9
Compare
ildyria
reviewed
May 19, 2020
ildyria
reviewed
May 19, 2020
ildyria
approved these changes
May 19, 2020
I think this would be a good idea. This would allow the use of the command to remove ghosts files (which is usually safe) while retaining the ability to not modify the database (for the photos). |
|
Changes made. Thanks! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Anything else I need to tackle before this gets merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #578
A couple of caveats here: I had to manually delete the 'big' file path even though we are calling
->delete()on the photo because inside thepredeletemethod,Storage::existsactually returnsfalseif you pass in a dead symlink. So a predelete and delete is not enough here, have to manually unlink the dead symlink itself.Something to consider: should this be an additional flag we pass into the ghostbuster command? I'm thinking in the event that images are mounted on an external drive, NFS, whatever and are 'temporarily' unavailable. Just something to keep in mind.