Add Diagnostics cache checks

app/Actions/Diagnostics/Errors.php

@@ -11,6 +11,7 @@
 use App\Actions\Diagnostics\Pipes\Checks\AdminUserExistsCheck;
 use App\Actions\Diagnostics\Pipes\Checks\AppUrlMatchCheck;
 use App\Actions\Diagnostics\Pipes\Checks\BasicPermissionCheck;
+use App\Actions\Diagnostics\Pipes\Checks\CachePasswordCheck;
 use App\Actions\Diagnostics\Pipes\Checks\ConfigSanityCheck;
 use App\Actions\Diagnostics\Pipes\Checks\CountSizeVariantsCheck;
 use App\Actions\Diagnostics\Pipes\Checks\DBIntegrityCheck;
@@ -54,6 +55,7 @@ class Errors
 		SmallMediumExistsCheck::class,
 		PlaceholderExistsCheck::class,
 		CountSizeVariantsCheck::class,
+		CachePasswordCheck::class,
 		SupporterCheck::class,
 	];
 

app/Actions/Diagnostics/Pipes/Checks/CachePasswordCheck.php

@@ -0,0 +1,38 @@
+<?php
+
+/**
+ * SPDX-License-Identifier: MIT
+ * Copyright (c) 2017-2018 Tobias Reich
+ * Copyright (c) 2018-2025 LycheeOrg.
+ */
+
+namespace App\Actions\Diagnostics\Pipes\Checks;
+
+use App\Constants\AccessPermissionConstants as APC;
+use App\Contracts\DiagnosticPipe;
+use App\DTO\DiagnosticData;
+use App\Models\Configs;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Schema;
+
+/**
+ * We check wether the config is set to use Cache and if there are password sets for albums.
+ */
+class CachePasswordCheck implements DiagnosticPipe
+{
+	/**
+	 * {@inheritDoc}
+	 */
+	public function handle(array &$data, \Closure $next): array
+	{
+		if (!Schema::hasTable('configs')) {
+			return $next($data);
+		}
+
+		if (Configs::getValueAsBool('cache_enabled') && DB::table(APC::ACCESS_PERMISSIONS)->whereNotNull('password')->count() > 0) {
+			$data[] = DiagnosticData::warn('Response cache is enabled and some albums are password protected.', self::class, ['Due to response caching, unlocking those albums will reveal their content to other annonymous users.']);
+		}
+
+		return $next($data);
+	}
+}

app/Http/Resources/Rights/AlbumRightsResource.php

@@ -10,6 +10,7 @@
 
 use App\Contracts\Models\AbstractAlbum;
 use App\Models\Album;
+use App\Models\Configs;
 use App\Policies\AlbumPolicy;
 use Illuminate\Support\Facades\Gate;
 use Spatie\LaravelData\Data;
@@ -27,6 +28,7 @@ class AlbumRightsResource extends Data
 	public bool $can_delete = false;
 	public bool $can_transfer = false;
 	public bool $can_access_original = false;
+	public bool $can_pasword_protect = false;
 
 	/**
 	 * Given an album, returns the access rights associated to it.
@@ -42,5 +44,6 @@ public function __construct(?AbstractAlbum $abstractAlbum)
 		$this->can_delete = Gate::check(AlbumPolicy::CAN_DELETE, [AbstractAlbum::class, $abstractAlbum]);
 		$this->can_transfer = Gate::check(AlbumPolicy::CAN_TRANSFER, [AbstractAlbum::class, $abstractAlbum]);
 		$this->can_access_original = Gate::check(AlbumPolicy::CAN_ACCESS_FULL_PHOTO, [AbstractAlbum::class, $abstractAlbum]);
+		$this->can_pasword_protect = !Configs::getValueAsBool('cache_enabled');
 	}
 }

lang/cz/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/cz/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/de/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/de/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/el/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/el/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/en/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/en/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/es/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/es/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/fr/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/fr/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/hu/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/hu/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/it/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/it/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/ja/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/ja/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/nl/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/nl/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/no/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/no/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/pl/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/pl/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/pt/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/pt/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/ru/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',

lang/ru/settings.php

@@ -35,6 +35,8 @@
 		'language' => 'Language used by Lychee',
 		'nsfw_album_visibility' => 'Make Sensitive albums visible by default.',
 		'nsfw_album_explanation' => 'If the album is public, it is still accessible, just hidden from the view and <b>can be revealed by pressing <kbd>H</kbd></b>.',
+		'cache_enabled' => 'Enable caching of responses.',
+		'cache_enabled_details' => 'This will significantly speed up the response time of Lychee.<br> <i class="pi pi-exclamation-triangle text-warning-600 mr-2"></i>If you are using password protected albums, you should not enable this.',
 	],
 	'lychee_se' => [
 		'header' => 'Lychee <span class="text-primary-emphasis">SE</span>',

lang/sk/dialogs.php

@@ -107,6 +107,7 @@
 		'password' => 'Password',
 		'password_prot' => 'Password protected',
 		'password_prot_expl' => 'Anonymous users need a shared password to access this album.',
+		'password_prop_not_compatible' => 'Response cache is conflicting with this setting.<br>Due to response caching, unlocking this album will<br>also reveal its content to other annonymous users.',
 		'nsfw' => 'Sensitive',
 		'nsfw_expl' => 'Album contains sensitive content.',
 		'visibility_updated' => 'Visibility updated.',