Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full permission check is now disabled by default. #3013

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Full permission check is now disabled by default. #3013

merged 1 commit into from
Feb 17, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Feb 17, 2025

As it slows down quite a bit the diagnostic page.

@ildyria ildyria requested a review from a team as a code owner February 17, 2025 08:04
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Feb 17, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.29%. Comparing base (a5ec8c2) to head (baf4462).
Report is 4 commits behind head on master.

Additional details and impacted files

d7415
d7415 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I wonder if it would be better behind a button rather than a config so that it can be run as a one-off.

That would also be more effort though.

@ildyria ildyria merged commit 44f9087 into master Feb 17, 2025
54 checks passed
@ildyria ildyria deleted the disable-recursive-permission-check branch February 17, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415