Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark all legacy classes as final #2928

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Mark all legacy classes as final #2928

merged 1 commit into from
Jan 18, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 18, 2025

KLO stuff

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 18, 2025
@ildyria ildyria requested a review from d7415 January 18, 2025 10:34
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (47a8e6f) to head (69c7865).
Report is 4 commits behind head on master.

Additional details and impacted files

d7415
d7415 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@ildyria ildyria merged commit 0869b18 into master Jan 18, 2025
52 checks passed
@ildyria ildyria deleted the final branch January 18, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

@tinohager tinohager tinohager approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ildyria @d7415 @tinohager