Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation improved and auto generated. #2812

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 16, 2024

Most of the changes are documentations.

The most important file is:
https://github.com/LycheeOrg/Lychee/blob/scramble-try-2/app/Http/Resources/OpenApi/DataToResponse.php
which basically enables us to parse Spatie Data classes and automatically generate the json responses.

@ildyria ildyria requested a review from d7415 December 16, 2024 13:20
@ildyria ildyria mentioned this pull request Dec 16, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 19.64286% with 45 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (d7a9383) to head (3eda601).
Report is 12 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 945b8cd into master Dec 17, 2024
52 checks passed
@ildyria ildyria deleted the scramble-try-2 branch December 17, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants