Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 - Remove some queries. #2455

Merged
merged 5 commits into from
Jun 8, 2024
Merged

2 - Remove some queries. #2455

merged 5 commits into from
Jun 8, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jun 8, 2024

Remove some N+1 queries.
Still a few more left to track...

@ildyria ildyria added this to the 5.3.1 milestone Jun 8, 2024
@ildyria
Copy link
Member Author

ildyria commented Jun 8, 2024

Doing rand() on count() + skip is faster than inRandomOrder().

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jun 8, 2024
@ildyria ildyria changed the title Remove some queries. 2 - Remove some queries. Jun 8, 2024
* Add missing primary key in Jobs_history + option to disable feedback completely. (#2457)
* Wrap collections to avoid double queries (#2458)
@ildyria ildyria merged commit 44af7b5 into composer-update Jun 8, 2024
10 checks passed
@ildyria ildyria deleted the hunt-for-n-plus-1 branch June 8, 2024 18:31
ildyria added a commit that referenced this pull request Jun 8, 2024
* Composer update: add all the required annotations for phpstan
* Remove some queries. (#2455)
* Remove middleware when we already passed the landing point (#2456)
* Add missing primary key in Jobs_history + option to disable feedback completely. (#2457)
* Wrap collections to avoid double queries (#2458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants