Add check and execute npm only if the package.json exists. #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jln646v could you double check on your end? I found it working locally. :) |
|
Can we just completely remove this npm part from the script and re-add it in the livewire PR? |
|
That was the other option. However people don't often update their git hooks, so for this reason I thought it was preferable to have both right from the start even if unused at the moment. |
|
Isn't this file auto-updated when executing the hook? |
Indeed, forgot about that. |
|
@qwerty287 ? :) |
qwerty287
approved these changes
Dec 2, 2023
|
Pulling latest master still results in the npm step running and same error about missing package.json |
|
You need to update your git hook (with the one in the script folder). That npm package.json is not going to be back before #2035 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2063
This is a temporary change as with Livewire the package.json will come back hence why I did not remove the command completely but added a simple check.