Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify photoId to photoID and albumId to albumID when found #2017

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Unify photoId to photoID and albumId to albumID when found #2017

merged 1 commit into from
Sep 16, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 16, 2023

cleaner code.

@ildyria ildyria marked this pull request as ready for review September 16, 2023 15:44
@ildyria ildyria requested a review from a team September 16, 2023 15:44
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Sep 16, 2023
@ildyria ildyria added this to the 4.12.1 milestone Sep 16, 2023
@codecov
Copy link

codecov bot commented Sep 16, 2023 •
edited
Loading

Codecov Report

Merging #2017 (c5b0d8a) into master (6aac878) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

Additional details and impacted files

@qwerty287
Copy link
Contributor

qwerty287 commented Sep 16, 2023 •
edited
Loading

We could apply the same for terms like URL, PHP etc. (if there are any)

@ildyria
Copy link
Member Author

ildyria commented Sep 16, 2023

We could apply the same for terms like URL, PHP etc. (if there are any)

I did not look for those, as I was working on the Livewire part. I was mostly concerned with the dispatch messages format between of components. It uses an array, and I wanted to be sure that the keys were all unified to avoid nasty surprises.

Also the attributes in the DB are like album_id ... snake_case.
This made this change a bit risky. Had to double check everything.

@ildyria ildyria merged commit 4a4005c into master Sep 16, 2023
27 checks passed
@ildyria ildyria deleted the unify-albumID_albumId_photoID_photoId branch September 16, 2023 19:07
@ildyria ildyria modified the milestones: 4.12.1, 4.13 Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @qwerty287