Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no log write access infinite loop #1991

Merged
merged 3 commits into from
Aug 25, 2023
Merged

fix no log write access infinite loop #1991

merged 3 commits into from
Aug 25, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Aug 24, 2023

Just noticed this error.
Better handling of it. :)

@ildyria ildyria requested a review from a team August 24, 2023 18:46
@ildyria ildyria added this to the 4.11.1 milestone Aug 24, 2023
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #1991 (62bf0d4) into master (3dd7dcc) will decrease coverage by 0.26%.
The diff coverage is n/a.

Additional details and impacted files

@d7415 d7415 changed the title fix no log write access inifinite loop fix no log write access infinite loop Aug 24, 2023
@ildyria ildyria merged commit cc9a6d4 into master Aug 25, 2023
29 checks passed
@ildyria ildyria deleted the fix-no-log-write-access-infinite-loop branch August 25, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
4.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @qwerty287