Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only apply explain when requested #1896

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Only apply explain when requested #1896

merged 1 commit into from
Jun 24, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jun 23, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #1896 (b96dcfd) into master (0525fa8) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files

@ildyria ildyria added the High Priority High priority issues label Jun 23, 2023
@ildyria ildyria added this to the 4.9.3 milestone Jun 23, 2023
@ildyria ildyria requested a review from a team June 23, 2023 23:27
d7415
d7415 approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Just a speed boost?

@ildyria
Copy link
Member Author

ildyria commented Jun 24, 2023

Looks reasonable. Just a speed boost?

more than that, for some reason there is a query that makes it not happy in the tests on MariaDB.
So I am disabling it for now so that tests are green again.

@ildyria ildyria merged commit 82681d7 into master Jun 24, 2023
@ildyria ildyria deleted the fix-ci branch June 24, 2023 07:29
ildyria added a commit that referenced this pull request Jun 24, 2023
@ildyria
Only apply explain when requested (#1896)
2f949ba
codehog pushed a commit to codehog/LycheeOrg.github.io that referenced this pull request Sep 16, 2023
@timo-reymann @ildyria
feat(LycheeOrg/Lychee#1896): Add guide for analytics tools (LycheeOrg#89
02dccff 
)

* style: Reformat code

- Use format strings for inline usage
- Add new lines according to python style guide

* feat: Add tracking docs

* fix gen.py

---------

Co-authored-by: ildyria <beviguier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
High Priority High priority issues
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ildyria @d7415 @qwerty287