Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execute custom js from custom #1697

Merged
merged 12 commits into from
Jan 31, 2023
Merged

execute custom js from custom #1697

merged 12 commits into from
Jan 31, 2023

Conversation

cshyam1892
Copy link
Contributor

No description provided.

@ildyria ildyria mentioned this pull request Jan 10, 2023
Merged
@cshyam1892 cshyam1892 changed the title execute custom js from footer_additional_text execute custom js from custom Jan 16, 2023
qwerty287
qwerty287 reviewed Jan 18, 2023
View reviewed changes
public/dist/custom.js Outdated Show resolved Hide resolved
@cshyam1892 cshyam1892 requested a review from qwerty287 January 22, 2023 10:08
ildyria
ildyria reviewed Jan 23, 2023
View reviewed changes
public/dist/custom.js Outdated Show resolved Hide resolved
ildyria
ildyria requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty close to be ready. 👍
See comments.

@cshyam1892 cshyam1892 requested a review from ildyria January 24, 2023 07:57
qwerty287
qwerty287 reviewed Jan 24, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@ildyria
Copy link
Member

ildyria commented Jan 25, 2023

@qwerty287 fixed it :)

@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Merging #1697 (d85c632) into master (8366849) will decrease coverage by 0.54%.
The diff coverage is 85.50%.

Additional details and impacted files

qwerty287
qwerty287 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back end seems fine. Frontend has one comment left (which I wrote just a few seconds ago).

ildyria
ildyria approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ildyria ildyria merged commit 096b7d8 into LycheeOrg:master Jan 31, 2023
@nicokaiser nicokaiser mentioned this pull request Feb 8, 2023
Closed
@ildyria ildyria mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cshyam1892 @ildyria @qwerty287