composer update #1571
composer update #1571
Conversation
|
@kamil4 Fixed. |
| @@ -53,7 +53,7 @@ | |||
| "laravel/framework": "^9.2", | |||
| "livewire/livewire": "^2.7", | |||
| "lychee-org/nestedset": "^6", | |||
| "lychee-org/php-exif": "^0.7.13", | |||
| "lychee-org/php-exif": "^0.7.14", | |||
There was a problem hiding this comment.
Just our of curiosity: Why do we always update the composer.json, too, even if we only increase patch levels?
IMHO, this is an unnecessary step. composer update creates a composer.lock which resolves all dependencies to its most recent version. IMHO, composer.json only defines a lower limit. This means lychee-org/php-exif": "^0.7.13 also includes 0.7.14 if this version is published.
There was a problem hiding this comment.
True, but why not? It's a minimal step (compared to opening and reviewing a PR, at least) and may catch some edge cases.
There was a problem hiding this comment.
I didn't realize that ^0.7.13 includes 0.7.14 (I've never actually bothered to find out what this syntax means -- where is it documented?). That's why I keep complaining about it, because I assume that @ildyria simply keeps forgetting to commit composer.json 😃.
There was a problem hiding this comment.
There was a problem hiding this comment.
One of the reason why is that we enforce the bug fix of #1548 rather than depending on the .lock especially if someone decides to stupidly do composer update --prefer-lowest.
Fixes #1548 properly.
I would say that this should be the last PR before 4.6.2 :)