Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File cleanups and remove Homestead #1563

Merged
merged 6 commits into from
Oct 20, 2022
Merged

File cleanups and remove Homestead #1563

merged 6 commits into from
Oct 20, 2022

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Oct 20, 2022 •
edited
Loading

  • delete travis file
  • delete codecov upload script
  • delete aliases file
  • rename readme.md -> README.md
  • remove contrib make targets
  • remove Homestead files + dependency

@qwerty287
Files cleanup
8c11730 
- delete travis file
- delete codecov upload script
- delete `aliases` file
- rename `readme.md` -> `README.md`
- remove `contributors` make targets
@qwerty287
Remove Homestead files
ecbb57e
@qwerty287
Merge remote-tracking branch 'origin/master' into file-cleanups
59e2178
@qwerty287 qwerty287 requested a review from a team October 20, 2022 08:01
@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #1563 (45710b9) into master (93dc082) will decrease coverage by 0.74%.
The diff coverage is n/a.

Additional details and impacted files

@ildyria
Copy link
Member

ildyria commented Oct 20, 2022

I don't think we want to remove server.php :/

ildyria
ildyria reviewed Oct 20, 2022
View reviewed changes
makefile Show resolved Hide resolved
nagmat84
nagmat84 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an easy PR. Deleted things are always good things 😄

I haven't test it. @qwerty287 I assume you did? I haven't checked where scripts/after.sh and scripts/codecov.sh might have been used or if they are still used somewhere. Have you greped for them? If they are called nowhere and our CI is still running, I guess it is fine to delete them.

@ildyria
Copy link
Member

ildyria commented Oct 20, 2022

after.sh may be used by docker but I'm not sure. @d7415 ?

@qwerty287
Copy link
Contributor Author

@ildyria I don't think so, searched for it in the docker repo, no result. This file was added for Homestead.

@qwerty287
Copy link
Contributor Author

And codecov.sh was only used for Travis CI we don't use anymore.

@d7415
Copy link
Contributor

d7415 commented Oct 20, 2022

after.sh may be used by docker but I'm not sure. @d7415 ?

I'm not at a PC, but I'm pretty sure it doesn't.

@qwerty287
Copy link
Contributor Author

@ildyria Can I go on with merging?

@ildyria ildyria merged commit 80bbd41 into master Oct 20, 2022
@ildyria ildyria deleted the file-cleanups branch October 20, 2022 11:32
@qwerty287 qwerty287 added this to the 4.6.2 milestone Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria left review comments

@nagmat84 nagmat84 nagmat84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@qwerty287 @ildyria @d7415 @nagmat84