Improve & fix CSP #1528
Merged
Improve & fix CSP #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
High Priority
d7415
reviewed
Sep 25, 2022
d7415
reviewed
Sep 25, 2022
nagmat84
requested changes
Sep 25, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
nagmat84
approved these changes
Sep 25, 2022
There was a problem hiding this comment.
Only one slight change, but otherwise it looks good to me. I haven't tested it again, because I am on a business trip and I am reading and typing from my smartphone. So I also skimmed the changes only. But I assume that all issues have been addressed. Hence, I don't want to block this PR with my previous review any longer.
d7415
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After further inspection on the findings of @maggick , it appears that CSP was disabled...
This updates the config file and aims to fix it.