Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning config table #1491

Merged
merged 12 commits into from
Sep 5, 2022
Merged

Cleaning config table #1491

merged 12 commits into from
Sep 5, 2022

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Aug 27, 2022

The values username and password from the config table are no longer used.

@ildyria ildyria requested a review from a team August 27, 2022 09:08
@ildyria ildyria added this to the 4.6.1 milestone Aug 27, 2022
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wrong frontend branch...

@ildyria
Copy link
Member Author

ildyria commented Aug 27, 2022

What the F is going on with the tests.

@ildyria ildyria changed the title Cleaning config table WIP Cleaning config table Aug 27, 2022
@ildyria ildyria requested a review from qwerty287 August 27, 2022 10:29
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #1491 (43ec386) into master (b31d345) will decrease coverage by 0.73%.
The diff coverage is 100.00%.

@nagmat84
Copy link
Collaborator

Is this still WIP as the title suggests? Then this PR should be converted into a draft and reviews being invited after it has been completed. Or isn't this WIP and the title is just misleading?

@ildyria ildyria changed the title WIP Cleaning config table Cleaning config table Aug 27, 2022
@ildyria
Copy link
Member Author

ildyria commented Aug 27, 2022

Is this still WIP as the title suggests? Then this PR should be converted into a draft and reviews being invited after it has been completed. Or isn't this WIP and the title is just misleading?

My mistake, no longer WIP because the last tests finally passes. I wanted to make sure it was not going to be merged until the tests pass (even though it was approved). :)

@nagmat84
Copy link
Collaborator

Is this still WIP as the title suggests? Then this PR should be converted into a draft and reviews being invited after it has been completed. Or isn't this WIP and the title is just misleading?

My mistake, no longer WIP because the last tests finally passes. I wanted to make sure it was not going to be merged until the tests pass (even though it was approved). :)

You now that there is the option to mark PRs as draft for exactly this use case?

@ildyria
Copy link
Member Author

ildyria commented Aug 27, 2022

I know and I am using it in the upgrade-laravel-9 one.
However I don't see any option to convert a PR back to a draft.

EDIT: Found it, just under reviewers. Not really visible. :(

app/Models/Configs.php Outdated Show resolved Hide resolved
tests/Feature/InstallTest.php Outdated Show resolved Hide resolved
tests/Feature/InstallTest.php Outdated Show resolved Hide resolved
ildyria and others added 2 commits August 27, 2022 14:37
Co-authored-by: Matthias Nagel <matthias.h.nagel@posteo.de>
tests/Feature/InstallTest.php Outdated Show resolved Hide resolved
@ildyria ildyria merged commit e18c16b into master Sep 5, 2022
@ildyria ildyria deleted the drop-admin-user-config branch September 5, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants