-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning config table #1491
Cleaning config table #1491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wrong frontend branch...
What the F is going on with the tests. |
Is this still WIP as the title suggests? Then this PR should be converted into a draft and reviews being invited after it has been completed. Or isn't this WIP and the title is just misleading? |
My mistake, no longer WIP because the last tests finally passes. I wanted to make sure it was not going to be merged until the tests pass (even though it was approved). :) |
You now that there is the option to mark PRs as draft for exactly this use case? |
I know and I am using it in the EDIT: Found it, just under reviewers. Not really visible. :( |
database/migrations/2022_08_27_110209_drop_admin_user_config.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthias Nagel <matthias.h.nagel@posteo.de>
resolve conflict.
The values
username
andpassword
from the config table are no longer used.