Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1473 #1475

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Fixes #1473 #1475

merged 1 commit into from
Aug 21, 2022

Conversation

nagmat84
Copy link
Collaborator

I decided to remove the tests for the various sub-folders below uploads/ completely, because if they do not exist, they are created on the fly via Flysystem.

@nagmat84 nagmat84 marked this pull request as ready for review August 21, 2022 11:05
@nagmat84 nagmat84 requested a review from a team August 21, 2022 11:05
@nagmat84 nagmat84 added the bug Something isn't working label Aug 21, 2022
@nagmat84 nagmat84 linked an issue Aug 21, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #1475 (752ff3b) into master (4aa4ffb) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. Also tested!

Your comment looks a bit like https://lycheeorg.github.io/docs/advanced-setups.html#separating-data-from-the-code

@nagmat84
Copy link
Collaborator Author

Your comment looks a bit like https://lycheeorg.github.io/docs/advanced-setups.html#separating-data-from-the-code

With one tiny, but extremely crucial difference. My comment says that the import folder must be pulled out from the directory where it is currently located, while the FAQ keeps it there. But the import folder is of a completely different nature than the other folders. The other folders contain files which are already part of the Lychee database, while import does not.

@nagmat84 nagmat84 merged commit 0f8d712 into master Aug 21, 2022
@nagmat84 nagmat84 deleted the fix-1473 branch August 21, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer not updated for v4.5.3 directories
2 participants