Cleanup download tests

[nagmat84]

This is a follow-up to #1453. I already wanted to do that yesterday, but wanted to keep the re-factoring out of #1453.

1. It moves all download tests from the general PhotosOperationsTest to the new and specialized test class PhotosDownloadTest in order to keep them together.
2. We test different ZIP archives in several tests. I moved the boiler-plate code to handle ZIP archives and make assertions about them into a new class AssertableZIPArchive

[codecov]

Codecov Report

Merging #1457 (c0e79ac) into master (420beb4) will decrease coverage by 0.81%.
The diff coverage is n/a.

[ildyria]

I am wondering if we should add a helper function which given a path foo/../bar/image.ext returns image.ext.
This would avoid having magic constants in our tests.

[nagmat84]

No need to add helper function for that. fileinfo (I believe, or pathinfo?) does the job.

But I am more curious where you want to use it?

[ildyria]

e.g. here:

$zipArchive->assertContainsFilesExactly([
	'train.jpg' => ['size' => filesize(base_path(self::SAMPLE_FILE_TRAIN_IMAGE))],
	'mongolia-1.jpeg' => ['size' => filesize(base_path(self::SAMPLE_FILE_MONGOLIA_IMAGE))],
	'mongolia-2.jpeg' => ['size' => filesize(base_path(self::SAMPLE_FILE_MONGOLIA_IMAGE))],

Well mongalia-1, and mongolia-2 are not helping... but here for example makes a bit more sense:

$zipArchive->assertContainsFilesExactly([
	self::MULTI_BYTE_ALBUM_TITLE . '/fin de journée.jpg' => ['size' => filesize(base_path(TestCase::SAMPLE_FILE_SUNSET_IMAGE))],
	self::MULTI_BYTE_ALBUM_TITLE . '/mongolia.jpeg' => ['size' => filesize(base_path(TestCase::SAMPLE_FILE_MONGOLIA_IMAGE))],
]);

[nagmat84]

At these places such a helper function does not help. The name of downloaded file is not based on the original name of the initially uploaded file, but on the title of the photo which has been assigned by Lychee.

[ildyria]

LGTM.