version 4.5.3

[ildyria]

version 4.5.3 + composer update to add php-exif v0.7.11

[kamil4]

I would prefer if #1432 is fully resolved before 4.5.3 is released.

[codecov]

Codecov Report

Merging #1447 (d81dbe0) into master (1dd9e41) will decrease coverage by 0.82%.
The diff coverage is 70.58%.

[nagmat84]

Me, too. Updating php-exif is only half of the solution, we also need to fix read_exif_data in Lychee and add a test for it using the broken sample picture.

I am a little bit surprised that we suddenly push out on release after the next.

[ildyria]

I am a little bit surprised that we suddenly push out on release after the next.

I was just matching the tags. Don't overthink it :)

[nagmat84]

Why are there so many changes in whitespace? This is annoying.

[qwerty287]

This was a php-cs-fixer update.

[nagmat84]

This was a php-cs-fixer update.

That is not a good point. Even if php-cs-fixer has been updated, then one can still configure the rules such that the old behaviour is preserved. In this case, the problematic options are blank_line_between_import_groups in combination with imports_order.

Let's say that we wanted to to change the current behaviour and let's say we decide to be PSR-12 compatible (see https://www.php-fig.org/psr/psr-12/#3-declare-statements-namespace-and-import-statements), then I would understand that. But the current change is not even achieve PSR-12 compatibility, but looks rather random as if nobody took care.

[nagmat84]

I added a test case for the bug in 1fd9381, ensured that it triggered the bug reported in #1432 and fixed it in 3ec0160.

[nagmat84]

I fixed some of the sporadic changes made by CS Fixer in bab6011. I haven't yet found out what newly introduced option controls the removal of parentheses.

Don't get me wrong. I am not against formatting changes. For example, I could envision to move to PSR-12 coding standard. But this decision should be made explicit and it should be in an independent PR. It should not happen accidentally and it should not be mixed with a PR which also introduces functional changes.

[nagmat84]

Formally, I am entitled to do a review (as @ildyria is the submitter), but I would prefer if someone else could to a review, because most of the actual changes are on me.

[ildyria]

Formally, I am entitled to do a review (as @ildyria is the submitter), but I would prefer if someone else could to a review, because most of the actual changes are on me.

I can do the review though. :)

[ildyria]

LGTM. ( I can't click approve though :( )

[kamil4]

I guess you should be good to go? 😄