Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1342 #1349

Merged
merged 3 commits into from
May 31, 2022
Merged

Fixes #1342 #1349

merged 3 commits into from
May 31, 2022

Conversation

nagmat84
Copy link
Collaborator

If a user is going to be deleted, ownership of photos and albums is re-assigned to the current user who requested the deletetion and all shares with this user are deleted.

@nagmat84 nagmat84 linked an issue May 26, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1349 (b8038bc) into master (ae955e1) will decrease coverage by 0.76%.
The diff coverage is 100.00%.

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested. Code looks sane.

app/Models/User.php Outdated Show resolved Hide resolved
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested as well, but looks good so far.

@nagmat84 nagmat84 merged commit 690ec0e into master May 31, 2022
@nagmat84 nagmat84 deleted the fixes_1342 branch May 31, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Account Fails:
3 participants