Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1330 #1339

Merged
merged 4 commits into from
May 24, 2022
Merged

Fixes #1330 #1339

merged 4 commits into from
May 24, 2022

Conversation

nagmat84
Copy link
Collaborator

Fixes a wrong update of the _lft, _rgt indices if multiple albums are deleted within the same request. The PR also includes a new test testMultiDelete which triggers the bug.

@nagmat84 nagmat84 linked an issue May 22, 2022 that may be closed by this pull request
Multi select Delete album errors #1330
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

qwerty287
qwerty287 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but untested from my side (except the automatic test).

qwerty287
qwerty287 approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter reported as working.

@nagmat84 nagmat84 merged commit ae955e1 into master May 24, 2022
@nagmat84 nagmat84 deleted the fixes-1330 branch May 24, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@ildyria ildyria Awaiting requested review from ildyria

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi select Delete album errors
2 participants
@nagmat84 @qwerty287