-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1337
Update dependencies #1337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am generally happy with this PR. Nothing against it. Just two questions about changes which I do not understand.
Co-authored-by: Matthias Nagel <matthias.h.nagel@posteo.de>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There is another more subtle blocker for an upgrade to Laravel 9. Laravel 8 ships with Flysystem version 1, while Laravel 9 took a big step to Flysystem version 3. Even if Larapass would not be a blocker, we had to rewrite a lot of code related to file handling. That's another reason why I should finish my work on EXIF/MIME/etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Markdown is used on the pages which don't have interfaces... Anyway, it will be used by the Livewire front-end to replace the PR of Kamil on using markdown on album descriptions. For Larapass, I need to have a look. I already started to work towards Laravel 9 at some point in the past, especially when php 8 was released. Didn't really had time to dig further... Priorities... |
You can use the MD parser which is integrated anyway due to Laravel dependencies. This way we can avoid duplicated libraries. |
Update all dependencies in composer.lock by running
composer update
and add required PHP extensions.Also I removed a Markdown parser which seems to be unused. Am I right that it can be removed?
Also update some dependencies in composer.json. The only dependencies here are Laravel itself (Larapass blocks an upgrade to Laravel 9) and php-ffmpeg which is blocked by our php-exif fork.