Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1337

Merged
merged 6 commits into from
May 23, 2022
Merged

Update dependencies #1337

merged 6 commits into from
May 23, 2022

Conversation

qwerty287
Copy link
Contributor

Update all dependencies in composer.lock by running composer update and add required PHP extensions.

Also I removed a Markdown parser which seems to be unused. Am I right that it can be removed?

Also update some dependencies in composer.json. The only dependencies here are Laravel itself (Larapass blocks an upgrade to Laravel 9) and php-ffmpeg which is blocked by our php-exif fork.

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #1337 (b2ce904) into master (7e9cf7c) will decrease coverage by 0.89%.
The diff coverage is 100.00%.

@qwerty287 qwerty287 requested review from ildyria and nagmat84 and removed request for ildyria May 21, 2022 10:41
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally happy with this PR. Nothing against it. Just two questions about changes which I do not understand.

.github/workflows/Build.yml Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
Co-authored-by: Matthias Nagel <matthias.h.nagel@posteo.de>
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nagmat84
Copy link
Collaborator

Also update some dependencies in composer.json. The only dependencies here are Laravel itself (Larapass blocks an upgrade to Laravel 9) and php-ffmpeg which is blocked by our php-exif fork.

There is another more subtle blocker for an upgrade to Laravel 9. Laravel 8 ships with Flysystem version 1, while Laravel 9 took a big step to Flysystem version 3. Even if Larapass would not be a blocker, we had to rewrite a lot of code related to file handling. That's another reason why I should finish my work on EXIF/MIME/etc.

Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ildyria
Copy link
Member

ildyria commented May 22, 2022

Markdown is used on the pages which don't have interfaces... Anyway, it will be used by the Livewire front-end to replace the PR of Kamil on using markdown on album descriptions.

For Larapass, I need to have a look. I already started to work towards Laravel 9 at some point in the past, especially when php 8 was released. Didn't really had time to dig further... Priorities...

@qwerty287
Copy link
Contributor Author

You can use the MD parser which is integrated anyway due to Laravel dependencies. This way we can avoid duplicated libraries.

@qwerty287 qwerty287 merged commit 68d60df into master May 23, 2022
@qwerty287 qwerty287 deleted the updates branch May 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants