-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing indices #1278
Add missing indices #1278
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM.
@nagmat84 I added a bump version to 4.5.1. Merge or revert. :)
I fear I haven't yet fully understood why we need these version bumps and when we add them. For example, we already have a couple of migrations after the last version bump and they just work well. I don't mind whether it is there or not. |
The bump of minor versions are mostly here when there is one of the following condition applied:
We are in the later case with a bunch of migrations that might have been waiting to be run.
Though in my opinion, the file_size_variants should have required a minor bump already... |
* Add missing indices * A workaround for MySQL * bump minor version Co-authored-by: ildyria <beviguier@gmail.com>
* Created actions * Added missing files and bug fix in condition. * Made album query more efficient * Moved file deletion after the response * Added index * Added proper PHPdoc comments. * Apply suggestions from code review Co-authored-by: Kamil Iskra <kamil.01482@iskra.name> * Add missing indices (#1278) * Add missing indices * A workaround for MySQL * bump minor version Co-authored-by: ildyria <beviguier@gmail.com> * Center search clear `X` (#1264) * Center search clear `X` * Use better syntax * Fix public search * Sync frontend * Build frontend * Possibly improved SQL query. * Avoid spaghetti code. * Increase efficiency * Added forgotten live photos * Removed unnecessary line breaks. * Fixed symbolic links for media files. * Fixed symlinks for regular media files and updated migration * Update app/Image/FileDeleter.php Co-authored-by: Kamil Iskra <kamil.01482@iskra.name> Co-authored-by: Kamil Iskra <kamil.01482@iskra.name> Co-authored-by: ildyria <beviguier@gmail.com> Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
See discussion on Gitter