Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing indices #1278

Merged
merged 3 commits into from
Apr 16, 2022
Merged

Add missing indices #1278

merged 3 commits into from
Apr 16, 2022

Conversation

nagmat84
Copy link
Collaborator

See discussion on Gitter

@nagmat84 nagmat84 requested a review from ildyria April 16, 2022 15:13
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #1278 (d6f4a93) into master (0199212) will decrease coverage by 0.96%.
The diff coverage is n/a.

@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

@nagmat84 I added a bump version to 4.5.1. Merge or revert. :)

@nagmat84
Copy link
Collaborator Author

nagmat84 commented Apr 16, 2022

I fear I haven't yet fully understood why we need these version bumps and when we add them. For example, we already have a couple of migrations after the last version bump and they just work well.

I don't mind whether it is there or not.

@ildyria
Copy link
Member

ildyria commented Apr 16, 2022

I fear I haven't yet fully understood why we need these version dumps and when we add them. For example, we already have a couple of migrations after the last version bump and they just work well.

I don't mind if it is there or not.

The bump of minor versions are mostly here when there is one of the following condition applied:

  • interesting minor changes added (e.g. support of the safe use of light sabers)
  • a migration that really helps with the use of Lychee and really needs to be run.

We are in the later case with a bunch of migrations that might have been waiting to be run.

| Yes  | 2022_01_13_183131_bump_version040500                        | 59    |
| Yes  | 2022_01_16_181337_optimize_tables                           | 60    |
| Yes  | 2022_02_02_203008_filesize_size_variants                    | 61    |
| Yes  | 2022_04_06_091900_drop_objectionable_indices                | 63    |
| Yes  | 2022_04_16_170724_add_missing_indices                       | 64    |
| No   | 2022_04_16_174503_bump_version040501                        |       |

Though in my opinion, the file_size_variants should have required a minor bump already...

@nagmat84 nagmat84 merged commit af768af into master Apr 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the add_missing_indices branch April 16, 2022 16:04
nagmat84 added a commit that referenced this pull request Apr 18, 2022
* Add missing indices

* A workaround for MySQL

* bump minor version

Co-authored-by: ildyria <beviguier@gmail.com>
nagmat84 added a commit that referenced this pull request Apr 21, 2022
* Created actions

* Added missing files and bug fix in condition.

* Made album query more efficient

* Moved file deletion after the response

* Added index

* Added proper PHPdoc comments.

* Apply suggestions from code review

Co-authored-by: Kamil Iskra <kamil.01482@iskra.name>

* Add missing indices (#1278)

* Add missing indices

* A workaround for MySQL

* bump minor version

Co-authored-by: ildyria <beviguier@gmail.com>

* Center search clear `X` (#1264)

* Center search clear `X`

* Use better syntax

* Fix public search

* Sync frontend

* Build frontend

* Possibly improved SQL query.

* Avoid spaghetti code.

* Increase efficiency

* Added forgotten live photos

* Removed unnecessary line breaks.

* Fixed symbolic links for media files.

* Fixed symlinks for regular media files and updated migration

* Update app/Image/FileDeleter.php

Co-authored-by: Kamil Iskra <kamil.01482@iskra.name>

Co-authored-by: Kamil Iskra <kamil.01482@iskra.name>
Co-authored-by: ildyria <beviguier@gmail.com>
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants