Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QR code locales #1260

Merged
merged 8 commits into from
May 5, 2022
Merged

Add QR code locales #1260

merged 8 commits into from
May 5, 2022

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 mentioned this pull request Apr 10, 2022
Merged
@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #1260 (c97e785) into master (5598e19) will decrease coverage by 1.20%.
The diff coverage is n/a.

@nagmat84
Copy link
Collaborator

nagmat84 commented May 3, 2022

Here is your rebased branch although it seems it is not necessary: https://github.com/LycheeOrg/Lychee/tree/qrcode-35_rebased

@qwerty287
Copy link
Contributor Author

A simple merge commit did it as well :)

@LycheeOrg LycheeOrg deleted a comment from sonarcloud bot May 4, 2022
nagmat84
nagmat84 approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qwerty287
Copy link
Contributor Author

Please note that the synced frontend also contains changes from the move from node-sass to sass, thus the CSS files have changed.

@qwerty287 qwerty287 merged commit 50dacef into LycheeOrg:master May 5, 2022
@qwerty287 qwerty287 deleted the qrcode-35 branch May 5, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

@kamil4 kamil4 kamil4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerty287 @nagmat84 @kamil4