Fix import of video files and thumbnail generation #1219

kamil4 · 2022-02-08T18:46:52Z

There were two separate bugs:

Extra dot being added to file extensions on import
Leftover invocation of Helpers::createTemporaryFile which doesn't exist as of Improved file handling #1203

I also noticed that we were attempting to generate medium/medium2x variants for video files. They are not necessary because the front end can't use them (it displays the video file using the video tag, rather than displaying a medium image like it does for photos). Or was this change intentional? I'm guessing it dates back to #1055.

nagmat84

LGTM. Identical to my bug fix, except for the additional removal of the medium size variants for videos.

nagmat84 · 2022-02-08T19:01:47Z

also noticed that we were attempting to generate medium/medium2x variants for video files. They are not necessary because the front end can't use them [...]. Or was this change intentional? I'm guessing it dates back to #1055.

No, the change wasn't intentional. Actually it was a pure oversight. One could argue that for sake of clearness and traceability it might be worth not to add any extra code paths for this particular front-end. Probably, in some years other programmers will ask the question, what is so special about videos to not generate the size variants. Saying that, we should at least add a comment. But I am fine with removing the size variants.