Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also support Caps on size format #1142

Merged
merged 1 commit into from
Nov 16, 2021
Merged

also support Caps on size format #1142

merged 1 commit into from
Nov 16, 2021

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 16, 2021

Just found out that if we have
Max uploaded file size: 500M
Then this will still raise the warning:
Warning: You may experience problems when uploading a large amount of photos. Take a look in the FAQ for details.

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1142 (0a5b27a) into master (815f896) will decrease coverage by 1.05%.
The diff coverage is 66.66%.

@ildyria ildyria mentioned this pull request Nov 16, 2021
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@ildyria ildyria merged commit f29922d into master Nov 16, 2021
@ildyria ildyria deleted the fix-diagnostics branch November 16, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants