Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lychee:video_data #1121

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Fix lychee:video_data #1121

merged 1 commit into from
Oct 20, 2021

Conversation

gpotter2
Copy link
Contributor

This PR fixes the lychee:video_data command.

Will attempt to generate up to 100 video thumbnails/metadata with a timeout of 600 seconds...
Processing XXX...
Extracted video frame for thumbnails

In ImageEditing.php line 170:

  Undefined property: App\Console\Commands\VideoData::$imageHandler

Are commands tested regularly? It would also appear that lychee:generate_thumbs is broken?

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #1121 (6665b9b) into master (2374a94) will decrease coverage by 1.75%.
The diff coverage is n/a.

@nagmat84
Copy link
Collaborator

Are commands tested regularly? It would also appear that lychee:generate_thumbs is broken?

Unfortunately not. The unit tests do not cover everything, especially the CLI is mostly untested.

@nagmat84
Copy link
Collaborator

PR looks good to me.

@nagmat84 nagmat84 merged commit 5e5ab73 into LycheeOrg:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpotter2 @nagmat84