Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish translation #923

Closed
elvisef opened this issue Feb 14, 2021 · 11 comments
Closed

Polish translation #923

elvisef opened this issue Feb 14, 2021 · 11 comments
Labels
Low Priority Low priority issues Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted

Comments

@elvisef
Copy link
Contributor

elvisef commented Feb 14, 2021

I am working on it, and it's almost done.
But some words made me think I cannot udnderstand it : ]

2021-02-14_16-36

Alright, what is a "sensitive" album ?
Maybe I did not read FAQ thoroughly but just in short, please.

Some words or sentences need to be longer, as for my language.
I tried to make it understandable and not so general in meaning some functions, in settings generally.

And if I'm done (I am working with GIT, but I am new to github pushing), do I need to use the master branch or how this should be properly done ?

@ildyria
Copy link
Member

ildyria commented Feb 14, 2021

Alright, what is a "sensitive" album ?

See here : #822 😆

And if I'm done (I am working with GIT, but I am new to github pushing), do I need to use the master branch or how this should be properly done ?

https://lycheeorg.github.io/docs/contributions.html#how-to-properly-submit-a-pull-request-to-lychee

@elvisef
Copy link
Contributor Author

elvisef commented Feb 14, 2021

Alright, thanks, piece of cake ; )

One question, shouldn't "Owner" be in the locale files as well ?
2021-02-14_19-32

I could not find it there.

And one more, I could not find "Tags" in locales:
2021-02-14_20-32

It's when I wanted to edit tags for an album.

Ooops, one more : ) "About" is missing as well. While translating I think this should be easily changeable.
2021-02-14_20-34

I'll try to find it in the code maybe. I will try to finish translating today or tomorrow max.
Will see how it looks :P

Anyway what exactly means "Take Date" or "Latest Take Date" ?
I suppose it could mean a date picture was taken, right ? Or not ?
It is confusing for me, sorry. If You could write what it means in other words, I will be happy.

@ildyria
Copy link
Member

ildyria commented Feb 15, 2021

There might indeed be missing some parts as you noticed for Owner, Tags, and other.

Now to answer your simpler questions:

  • "Take Date" is the date the picture is taken (obviously)
  • "Latest Take Date" and "Oldest Take Date" refers respectively to the maximum and minimum value of "Take Date" in an album: your pictures may not be taken all on the same date. As a result, you may want to order your albums by using the oldest picture in that album or the youngest. This has no influence on the picture ordering inside the album, this is only of the album ordering.

@ildyria ildyria added Low Priority Low priority issues Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted labels Feb 15, 2021
@zaisty
Copy link

zaisty commented Jun 13, 2021

Hi @elvisef !
Im looking forward for Your Polish translation when it will be ready.
Keep up good work.
Thank You and good luck!

@elvisef
Copy link
Contributor Author

elvisef commented Jul 11, 2021

Oh yeah, I had no time lately, but it is translated almost whole.
I will look into it today and let You know. Will try then to make a push with this translation.

I suppose, my translation will be changed somehow according to the most appropriate words or phrases used, by other users, but at least the polish will be usable : )

@elvisef
Copy link
Contributor Author

elvisef commented Jul 17, 2021

Alright, I need help. I did what's written here: https://lycheeorg.github.io/docs/contributions.html#how-to-properly-submit-a-pull-request-to-lychee but can't push my changes due to 403 error... What am I doing wrong ?

2021-07-17_19-07

@ildyria
Copy link
Member

ildyria commented Jul 17, 2021

Ah, I see the error. And it is our fault, we did not make it explicit that you had to create a fork of the repository.

LycheeOrg/LycheeOrg.github.io#32 < Improve documentation...

You are trying to push it to the main repo, but because you are not part of the organization yo don't have such rights.

So. you need to do a fork of the repository, then you do

git remote add elvisef https://github.com/elvisef/Lychee/
git push -u elvisef <your branch name>

This will push the branch to your repository.
After which you can make a pull request between the branch on your repo and the master branch of this repository. 👍

If you have more questions, don't hesitate.

elvisef pushed a commit to elvisef/Lychee that referenced this issue Jul 17, 2021
@elvisef
Copy link
Contributor Author

elvisef commented Jul 17, 2021

Thanks for info. I wasn't aware.
Alright, I think the pull request was automatically added.
Let me know if everything is ok.

@ildyria
Copy link
Member

ildyria commented Jul 17, 2021

@elvisef
Copy link
Contributor Author

elvisef commented Jul 17, 2021

Alright, so i will need to compare my file to the newest English..
I will do that asap I suppose.

@ildyria
Copy link
Member

ildyria commented Oct 30, 2021

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Low priority issues Project for volunteers The team has no plans to work on it (e.g. lack of time) but an external contribution is accepted
Projects
None yet
Development

No branches or pull requests

3 participants